* fix: arguments accept units
`max-body-size` and `read-buffer-size` now accept units as defined in the docs.
Fixes#1489
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: modify logic to comply with vetting
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt -w .
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: set defaults
`max-body-size` is defaulted to 4Mi
`request-buffer-size` is defaulted to 4Ki
This is inline with the runtime.
Signed-off-by: Mike Nguyen <hey@mike.ee>
* fix: set defaults in run and annotate
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: exit with error rather than panic
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Mike Nguyen <hey@mike.ee>
---------
Signed-off-by: Mike Nguyen <hey@mike.ee>
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
The issue found when similar resource were installed in k8s that use the name "configurations".
In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error
`Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not found`
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Scheduler: set broadcast address to localhost:50006 in selfhosted
Signed-off-by: joshvanl <me@joshvanl.dev>
* Set schedulder override flag for edge and dev
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
* fix: population of the schedulerhostaddress in self-hosted mode
The scheduler host address is pre-populated when using the self-hosted mode multi-app run similarly to the single app run.
Kubernetes multi-app run is not affected and you will still need to specify a scheduler host address.
Signed-off-by: mikeee <hey@mike.ee>
* chore: lint
Signed-off-by: mikeee <hey@mike.ee>
---------
Signed-off-by: mikeee <hey@mike.ee>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
* Update dependencies, Go version and address CVEs
Signed-off-by: Anton Troshin <anton@diagrid.io>
* update golangci-lint version and list of disabled linters form dapr/dapr
Signed-off-by: Anton Troshin <anton@diagrid.io>
* adjust golangci-lint settings and fix lint issues
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix test
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
* add image pull policy
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* add allowed values
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* feedback refactor allowed values name
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* add unit tests
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* lint
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* lint
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* more lint
Signed-off-by: Filinto Duran <filinto@diagrid.io>
* more lint
Signed-off-by: Filinto Duran <filinto@diagrid.io>
---------
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Co-authored-by: Anton Troshin <anton@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee>
* Add version parsing check skip malformed versions and avoid panic
Signed-off-by: Anton Troshin <anton@diagrid.io>
* lint
Signed-off-by: Anton Troshin <anton@diagrid.io>
* do not return error on nil, skip bad versions
Signed-off-by: Anton Troshin <anton@diagrid.io>
* simplify condition to skip prerelease and versions with metadata
print warning on error and non-semver version tag
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Fix tests running master in CI with specific dapr version
Signed-off-by: Anton Troshin <anton@diagrid.io>
* move env version load into common
Signed-off-by: Anton Troshin <anton@diagrid.io>
* fix k8s test files
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Revert "fix k8s test files"
This reverts commit 344867d19ca4b38e5a83a82a2a00bb04c1775bab.
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Revert "move env version load into common"
This reverts commit 39e8c8caf54a157464bb44dffe448fc75727487f.
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Revert "Fix tests running master in CI with specific dapr version"
This reverts commit a02c81f7e25a6bbdb8e3b172a8e215dae60d321f.
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Add GetRuntimeVersion to be able to compare semver dapr versions for conditional tests
Use GetRuntimeVersion in test
Signed-off-by: Anton Troshin <anton@diagrid.io>
---------
Signed-off-by: Anton Troshin <anton@diagrid.io>
* Give scheduler a default volume, making it resilient to restarts by
default
Signed-off-by: joshvanl <me@joshvanl.dev>
* Remove dapr_scheduler volume on uninstall, gated by `--all`
Signed-off-by: joshvanl <me@joshvanl.dev>
* Fix containerErrs in standaone.go
Signed-off-by: joshvanl <me@joshvanl.dev>
* Do not attempt to delete scheduler volume if no container runtime
Signed-off-by: joshvanl <me@joshvanl.dev>
* Increase upgrade test timeout to 40m
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* dapr_scheduler: pre-create data dir
Signed-off-by: joshvanl <me@joshvanl.dev>
* Adds --scheduler-volume to specify volume for data directory
Signed-off-by: joshvanl <me@joshvanl.dev>
---------
Signed-off-by: joshvanl <me@joshvanl.dev>
* fix: scheduler host address passed to runtime
Signed-off-by: mikeee <hey@mike.ee>
* fix: scheduler client stream initialised for 1.14<
Signed-off-by: mikeee <hey@mike.ee>
* fix: modify scheduler host address validation
if the scheduler container is not active, the scheduler flag will
not be passed to the runtime
Signed-off-by: mikeee <hey@mike.ee>
* fix: lint and refactor
Signed-off-by: mikeee <hey@mike.ee>
---------
Signed-off-by: mikeee <hey@mike.ee>
* wip
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* rm scheduleJob logic. keep only init/uninstall logic
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
* Fixes install and uninstall of scheduler in standalone mode.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fixing path for Go tools in Darwin.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix Go bin location for MacOS.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix min scheduler version to be 1.14.x
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Use env var to pass scheduler host.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* Fix CLI build to work with latest MacOS runners from GH
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
---------
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
Anton Troshin