discourse
/
discourse-assign
mirror of https://github.com/discourse/discourse-assign.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
240 Commits 18 Branches 0 Tags 4.5 MiB
Commit Graph

240 Commits

Author SHA1 Message Date
Sam Saffron 68ff24739b DEV: attempt a more cautious lookup 
This was failing the test suite somehow, despite voting using the same
pattern.
 2019-11-01 15:26:16 +11:00
Sam Saffron e0de9238a1 FEATURE: new category setting to add "Unassigned" navigation menu 
When a category is used exclusively for managing topic assignments it can
be very useful to list all the unassigned topics. This introduces a new
category setting that allows admins to opt for this new navigation item.

It works both on mobile and desktop.

This uses an amended nav item API, to experience this fully you need latest
versions of Discourse.
 2019-11-01 14:15:28 +11:00
Sam Saffron bc5469c6c6 Revert "FEATURE: new category setting to add "Unassigned" navigation menu" 
This reverts commit 600e1b6544.

The level of hack here is just to high, this destabilizes tests. We need a
proper pattern.
 2019-10-30 18:16:12 +11:00
Sam Saffron abc21b7734 Revert "DEV: make pre-initializer a bit safer" 
This reverts commit 029a26733a.

This whole experiment is too unstable
 2019-10-30 18:13:30 +11:00
Sam Saffron 029a26733a DEV: make pre-initializer a bit safer 
Was noticing custom fields could be null is some cases so this ensures we
never reach to it if missing
 2019-10-30 17:55:50 +11:00
Bianca Nenciu cbab25356b DEV: Use BasicUserSerializer for assigned user (#53) 2019-10-30 17:13:08 +11:00
Sam Saffron ce63380eb5 DEV: Missed running prettier automatically 
This is not fixed in my dev environment
 2019-10-30 17:07:40 +11:00
Sam Saffron 600e1b6544 FEATURE: new category setting to add "Unassigned" navigation menu 
When a category is used exclusively for managing topic assignments it can
be very useful to list all the unassigned topics. This introduces a new
category setting that allows admins to opt for this new navigation item.

It works both on mobile and desktop.

Unfortunately Discourse is lacking internal APIs for cleanly adding NavItems

We will look at improving this soon.
 2019-10-30 16:37:13 +11:00
Régis Hanol 9c2ebbaaf5 FIX: do not self-assign based on quoted text 
Remove any quoted text and code blocks before matching the "assign self" or "assign other" regexps.

Added tests to ensure it does not regress.

Also cleaned up some TODOs.
 2019-10-29 19:00:39 +01:00
Vinoth Kannan b3c2b83ad8 DEV: minor refactoring to reduce DB queries. 2019-10-25 17:35:05 +05:30
Vinoth Kannan eb02ac1ef5 FIX: always include admins in 'assign' allowed users list. 2019-10-25 17:27:38 +05:30
Dan Ungureanu 1a041b49e0
FIX: Use TopicList's preloaded_custom_fields. 2019-10-21 19:42:04 +03:00
Neil Lalonde d4d249d525 Update translations 2019-10-10 11:24:36 -04:00
romanrizzi a6df22bb32 DEV: Remove old backward-compatibility code 2019-10-09 15:21:00 -03:00
Jeff Wong e96e67bfbb Add support for unicode usernames 2019-09-20 14:12:23 -07:00
Bianca Nenciu b96379e9b1 DEV: Simplify unit test 2019-09-18 22:24:40 +03:00
Bianca Nenciu eb2359dca1 DEV: Add test for assigned 
Follow-up to c46764e804
 2019-09-18 18:22:21 +03:00
Krzysztof Kotlarek d59e7fe1fb FIX: Use top-level namespace for base classes (#52) 2019-09-16 13:39:32 -04:00
Bianca Nenciu c46764e804
FEATURE: Add endpoint to list all assignments, sorted by user 
Includes a fix to let all admin users to use plugin
 2019-09-16 13:41:10 +03:00
Kyle Zhao 653a529dd9 TEST: Acceptance test for quick access assignments (#51) 2019-09-13 14:33:10 -04:00
Kyle Zhao c1c06b8ed6 FIX: do not escape `fancy_title` again. (#50) 2019-09-13 14:32:40 -04:00
romanrizzi 23904fcc3b DEV: Remove deprecated spec 2019-09-12 09:35:28 -03:00
romanrizzi 3b2f10a450 Remove fallback PM tag 2019-09-11 17:14:48 -03:00
Roman Rizzi dc6041abcb
DEV: Remove dreprecated review queue code (#47) 2019-09-11 09:51:23 -03:00
Bianca Nenciu 927fdca0a0 DEV: Test if assign_allowed_on_groups contains only visible groups 
Follow-up to 7d4b515524.
 2019-09-11 14:10:58 +03:00
Kyle Zhao d18c347cd9 FEATURE: Quick access panel for assignments. (#49) 
* FEATURE: Quick access panel for assignments.

* Only enable quick access when core is compatiable.

This ensures that the plugin won't break Discourse instances without the
latest `QuickAccessPanel` feature.
 2019-09-09 16:12:14 +10:00
Bianca Nenciu 7d4b515524 FIX: Suggest only groups that are visible to current user (#48) 
Otherwise, the user would search in groups that were not visible,
operation which resulted in a 403 error.
 2019-09-09 15:32:50 +10:00
Roman Rizzi d268d4f817
Fix: Enforce new rules when assigning a topic. (#46) 
* assign_to user must be allowed to assign.
* assign_to user must have access to the topic
 2019-09-05 10:31:52 -03:00
romanrizzi 2d78151481 FIX: Use can_assign instead of staff to show the assign modal correctly 2019-08-04 18:30:28 -03:00
David Taylor 9c72a2f5ca UX: Add "Assigned" to the page title for the assigned topic list 2019-08-02 15:51:14 +01:00
Penar Musaraj 2ddc5c5bef Make Rubocop happy 2019-07-29 21:33:25 -04:00
romanrizzi 8114684ed8 Initialize allowedGroups inside the constructor 2019-07-24 12:17:42 -03:00
romanrizzi 65fbdc3396 FIX: remove unused import 2019-07-19 14:55:36 -03:00
romanrizzi 8792cf51bd DEV: Assign allowed groups are sent alongside suggestions. After the migration happens, we'll need to still have access to the allowed group names so we can search users. 2019-07-19 14:49:45 -03:00
Roman Rizzi 64324ce9db
DEV: use group ids to allow assign on groups [Undo Revert] (#41) 
* DEV: use group ids to allow assign on groups (#38) [Undo Revert]

This reverts commit 8f92c5f9bd.

* Set the  default inside a migration based on the core migration. Improve migration check to work against tests-passed/beta/stable.

* Update db/migrate/20190718144722_set_assign_allowed_on_groups_default.rb

Co-Authored-By: Robin Ward <robin.ward@gmail.com>
 2019-07-19 10:30:44 -03:00
Joffrey JAFFEUX 49474c94ea
FIX: uses taskActions api and removes old buttons (#44) 2019-07-19 13:32:08 +02:00
Joffrey JAFFEUX 02c6fa6d24
DEV: uses new topic-button API (#43) 2019-07-19 10:20:55 +02:00
Joffrey JAFFEUX 75c6cecfdb
REFACTOR: old ember patterns, deprecations, dead code (#42) 2019-07-19 09:56:39 +02:00
Roman Rizzi 8f92c5f9bd
Revert "DEV: use group ids to allow assign on groups (#38)" (#40) 
This reverts commit b256d462bf.
 2019-07-16 11:59:33 -03:00
Roman Rizzi b256d462bf
DEV: use group ids to allow assign on groups (#38) 
* DEV: use group ids to allow assign on groups

* FIX: Dinamically sets the default value to support older versions
 2019-07-16 11:33:04 -03:00
Neil Lalonde 439ebf44ec Update translations 2019-07-15 14:00:07 -04:00
Gerhard Schlager 6d44f4fe29 FIX: Send assignment message in the notified user's locale 2019-07-12 12:08:22 +02:00
Dan Ungureanu dea72e708b FIX: Skip enqueuing reminders if no groups are allowed. (#39) 
* FIX: Skip enqueuing reminders if no groups are allowed.

With an empty SiteSetting.assign_allowed_on_groups, it used to generate
an invalid query containing "group_users.group_id IN ()".
 2019-07-10 09:58:35 +02:00
Bianca Nenciu 22129d191f
UX: In mobile view show button only under topic controls. (#35) 2019-06-25 16:05:09 +03:00
Sam Saffron e4be0f02b7 Revert "Staff is always allowed to assign (#36)" 
This reverts commit bb200f5fbd.
Unfortunately that commit broke assign
 2019-06-18 16:00:10 +10:00
Neil Lalonde e1cc07adb1 Update translations 2019-06-17 13:56:40 -04:00
Roman Rizzi bb200f5fbd
Staff is always allowed to assign (#36) 2019-06-17 10:11:00 -03:00
Joffrey JAFFEUX 5bbca9b925 DEV: new API s/replaceCurrentUser/updateCurrentUser 2019-06-14 14:38:10 +02:00
Joffrey JAFFEUX fe80298ae5 FIX: prevents messageBus subscriptions to leak 2019-06-12 10:20:34 +02:00
Neil Lalonde 2aaa5a920f Update translations 2019-06-10 10:38:24 -04:00