Commit Graph

689 Commits

Author SHA1 Message Date
Bianca Nenciu a9b44a973c
FIX: Use same limit as default for user search (#437) 2023-01-26 16:28:30 +02:00
Bianca Nenciu f34bc92b40
FIX: Do not expand if assignee username present (#434)
This does not work as expected and can lead to a worse user experience.
2023-01-25 10:08:34 +02:00
Discourse Translator Bot 7e7da1a876
Update translations (#436) 2023-01-24 16:30:42 +01:00
chapoi 0c0fcbc5af
UX: fix list being limited by modal size (#435) 2023-01-24 13:19:01 +01:00
chapoi 4934df94e2
UX: add ellipsis for assign modal (#433)
* UX: add ellipsis for assign modal

* UX: remove suggestions label
2023-01-23 18:48:17 +01:00
chapoi 0d695df595
UX: fixing alignment issue (#432)
* UX: fixing alignment issue
2023-01-23 18:47:00 +01:00
Krzysztof Kotlarek c036d030dc
FIX: reassign when assignment limit is fulfilled (#419)
Previously, when topic was already assigned 5 times, reassign was not possible. User had to first unassign topic and then assign to someone else.
2023-01-20 13:34:22 +11:00
Selase Krakani 803f73f837
FIX: Deactivate active assignments attached to deleted targets (#428)
Before the implementation of the `post_destroyed` event handler in
the plugin, soft deleting assigned posts/topics did not deactivate the
assignment.
This left sites which assigned and deleted posts/topics before the
introduction of the event handler with 'orphaned' assignments in the UI.

This change deactivates these orphaned assignments.
2023-01-18 19:53:20 +00:00
Bianca Nenciu 02b9d9423e
UX: Add suggestions label to assign modal (#429) 2023-01-18 17:43:23 +02:00
Discourse Translator Bot a20eed02f3
Update translations (#431) 2023-01-18 11:42:05 +01:00
Jan Cernik a7df68b9c2
FIX: System tests failing due to assignee chooser (#430)
Since now the assignee chooser opens automatically, clicking on it was causing it to close
2023-01-17 09:55:21 -03:00
Jan Cernik 896d0e3445
FIX: Broken posts when assigning a closed topic (#425)
The previous behavior was:
1. Assign a topic to someone
2. Close the topic with the setting unassign_on_close enabled
3. Assign the topic to the same user as before

This caused small broken or empty posts to be displayed.

This commit also introduces system specs
2023-01-17 08:09:35 -03:00
Bianca Nenciu 6672ad1ff4
FEATURE: Automatically open assignee chooser (#427) 2023-01-13 17:22:13 +02:00
Bianca Nenciu 1268048874
FEATURE: Show user status when search assignees (#426)
The suggestions are displayed in email-group-user-chooser and user
status is displayed if it exists.
2023-01-12 22:31:48 +02:00
Discourse Translator Bot 4b430ae36e
Update translations (#423) 2023-01-10 20:53:45 +01:00
discoursebot 4eeee568af
DEV: Update CI workflows (#424)
Co-authored-by: discoursebuild <build@discourse.org>
2023-01-10 18:03:19 +00:00
chapoi 509ee637cf
UX: fix text alignment assign modal dropdown (#422) 2023-01-06 14:09:27 +01:00
Ted Johansson 31389d713a
FIX: Build correct assign tag links when using subfolders (#420)
The tag links added to the topic header extras aren't aware of
subfolder usage. This change fixes that.
2023-01-05 16:04:14 +08:00
David Taylor 4070985316
DEV: Update eslint-config-discourse, use prettier for hbs (#414) 2023-01-04 13:34:49 +01:00
Alan Guo Xiang Tan 4fe2ded608
DEV: Change flaky spec to provide more information when it fails (#418)
This spec has been detected to be flaky by
https://github.com/discourse/flaky-tests-detective which we run
internally. However, I could not reproduce the flakiness after multiple
attempts so I rewrote the assertions such that we set up the
expectations of what `Assignment#assigned_to_id` should be before and
after the triggering of the DiscourseEvent.
2023-01-04 07:27:23 +08:00
Gerhard Schlager 4777d0179c
UX: Rephrase notification message (#417)
* UX: Rephrase notification message

* Fix specs
2023-01-03 21:25:13 +01:00
Discourse Translator Bot 5d7c4ed8f7
Update translations (#416) 2023-01-03 14:45:59 +01:00
Discourse Translator Bot fd68f4266a
Update translations (#415) 2022-12-30 17:49:39 +01:00
dependabot[bot] c1f67664fc
Build(deps): Bump json5 from 2.2.1 to 2.2.2 (#413)
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-29 12:21:44 -05:00
David Taylor b11a5fd391
DEV: Introduce syntax_tree for ruby formatting (#411) 2022-12-29 13:30:03 +01:00
Discourse Translator Bot 9cf451647f
Update translations (#410) 2022-12-28 13:31:58 +01:00
David Taylor 46dd26963c
DEV: Introduce syntax_tree for ruby formatting (#408) 2022-12-23 20:35:55 +00:00
David Taylor 4902ba6993
DEV: Bump rubocop-discourse and correct violations (#409) 2022-12-23 19:55:31 +00:00
Bianca Nenciu 993f7faa8d
FIX: Reset assignee error when modal is shown (#407) 2022-12-21 17:24:17 +02:00
Bianca Nenciu a4ce90e855
UX: Improve assign modal design (#403)
Implements a new design that improves the user experience:

- add a clear cancel button
- add an indication the note is optional
- change the plus icon to a search icon
- show an error when the user tries to assign without choosing an assignee
- move suggestions to default search results
- focus search input when modal is displayed
2022-12-21 14:49:24 +02:00
Rafael dos Santos Silva 700dfe551b
DEV: Ruby 3.1 compat (#406) 2022-12-20 23:17:15 -03:00
Bianca Nenciu eeccf78c1e
DEV: Admins and mods are already members of staff (#404)
This hack is no longer necessary because fabricated admins and mods are already members of the staff group.
2022-12-20 16:24:21 +02:00
Discourse Translator Bot 212a12d709
Update translations (#405) 2022-12-20 15:22:24 +01:00
Bianca Nenciu d8821aa16d
DEV: Promote historic post_deploy migrations (#402)
This commit promotes all post_deploy migrations which existed in
Discourse v2.8.0 (timestamp <= 20220107014925)
2022-12-19 17:28:09 +02:00
Kris f19cc66b68
UX: update small actions to use sentence case (#401) 2022-12-14 13:28:07 -05:00
Andrei Prigorshnev 31d1a798f4
FEATURE: do not suggest users on vacation (#395) 2022-12-14 12:42:17 +04:00
Alan Guo Xiang Tan feca27b6bd
FEATURE: Make plugin compatible with redesigned user messages (#399) 2022-12-07 06:22:14 +08:00
Discourse Translator Bot 889df32cc6
Update translations (#398) 2022-11-29 15:35:41 +01:00
Joshua Rosenfeld 4200f1580a
Bump eslint-config-discourse from 1.1.8 to 3.3.0 (#397) 2022-11-29 00:20:48 +01:00
dependabot[bot] 969ee0e70a
Build(deps): Bump minimatch from 3.0.4 to 3.1.2 (#396)
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-27 17:33:07 +01:00
Penar Musaraj 4b8afc301a
FEATURE: Cleanup notifications when reassigning (#394)
If a topic is initially assigned to user A then reassigned to user B,
this change will make it so that notifications sent to user A are
removed. This matches the plugin's behaviour when unassigning a topic.
2022-11-24 10:42:19 -05:00
discoursebot 1f2dfafcde
DEV: Update CI workflows (#393)
Co-authored-by: discoursebuild <build@discourse.org>
2022-11-07 12:43:35 -06:00
Discourse Translator Bot d8a2e42f79
Update translations (#391) 2022-11-02 15:13:07 +01:00
Alan Guo Xiang Tan ed1b344d32
DEV: Persist records to DB in tests (#390)
There is almost no reason for us to use `Fabricate.build` which does not persist the record to the database and is not what we encounter in production.
2022-10-21 17:47:29 +08:00
Martin Brennan 7ec6c78aa2
DEV: Fix test for core change (#389)
This slight core change breaks this test

https://github.com/discourse/discourse/pull/18691
2022-10-21 14:16:41 +10:00
Jarek Radosz 5eee863d01
DEV: Clean up tests (#388) 2022-10-07 10:51:37 +02:00
Discourse Translator Bot 17bcfde257
Update translations (#387) 2022-10-05 15:31:23 +02:00
Martin Brennan a0202acdfa
DEV: Fix specs for personal_message_enabled_groups setting (#386)
See https://github.com/discourse/discourse/pull/18437,
we are removing any references to enable_personal_messages
in core and using only personal_message_enabled_groups,
which requires auto groups to be assigned in certain specs
for them to keep working.
2022-10-04 14:19:35 +10:00
Bianca Nenciu af146fea54
FIX: Show group icon for group notifications (#384)
The same "user-plus" icon was used for both user and group assigned
notifications.
2022-10-03 21:13:34 +03:00
David Taylor 9321e9bd41
DEV: Bump rubocop-discourse (#385) 2022-10-03 20:12:55 +02:00