Commit Graph

464 Commits

Author SHA1 Message Date
Cijo Thomas 6dbc69f76b
Add Mikel as maintainer (#805)
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
2020-07-16 14:25:10 +01:00
Eddy Nakamura 5b34e3b3f8
Adding metapackages (#810)
Adding IsPackable to test.props, updating test nuget versions

updating projects, adding options parameter

Applying suggestions

Apply suggestions from code review

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

code review - cijo

removing aspnetcore "metapackage"

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 23:31:57 -07:00
Rajkumar Rangaraj 9467014b72
Changed dipsose pattern in test (#833) 2020-07-15 22:17:07 -07:00
Peter Wiese b319c0bed6
Replace references to SpanAttributeConstants with constants from SemanticConventions (#828)
* Replace references to SpanAttributeConstants with constants from SemanticConventions

* Missed a few references to the "component" attribute in some tests.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 17:27:21 -07:00
Eddy Nakamura 52955d3f1f
Changing Zpages to Activity style (#821)
* Changing Zpages to Activity style

renaming file

Adding OT.Exporter.ZPages.Tests

updating targetframeworks

renaming classes

adding default value

* removing unused variables, applying vs suggestions

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 16:46:17 -07:00
Tom Tan 379d26a3f9
Add sample command line to export to OTel (#827)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 10:13:42 -07:00
Cijo Thomas a9713c8d01
Delete BatchingSpanProcessorTest (#825) 2020-07-14 23:47:04 -07:00
Peter Wiese 80e7bd09ec
Adding a SemanticConventions static class that contains the current set of semantic attribute names as of 709293fe13/specification/trace/semantic_conventions (#820)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-14 23:18:03 -07:00
Cijo Thomas 16752a25ed
Removed leftover SpanExtension file from OTLP exporter (#818) 2020-07-14 23:01:10 -07:00
Cijo Thomas 2712d4b29b
More cleanup - zipkin exporter removed span related code (#823) 2020-07-14 22:54:23 -07:00
Cijo Thomas 59f0a9d06a
Modified B3Format propogator to use ActivityContext (#822) 2020-07-14 22:15:25 -07:00
Rajkumar Rangaraj efaa6f61fc
Update otlp test (#824) 2020-07-14 18:37:08 -07:00
Rajkumar Rangaraj 4eece94ec6
Add status to activity (#802)
* Extension method to support Status.

* Added tests and status support for otlp.

* Fix test

* Added description to Status API

* Resolving conflict

* Resolve conflict

* Avoid status object allocation.

* Check for null

* Resolving conflict

* resolving conflict

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-14 16:16:32 -07:00
Cijo Thomas 7960b2903a
Make Activity.SetStatus internal as users set Resource on a different level (#816)
* Make Activity.SetStatus internal as users set Resource on a different level.

* fix test build

* fix tests to properly set resouce on activity
2020-07-14 14:57:21 -07:00
Cijo Thomas d4fbd7a8bd
More stabilization to tests (#815)
* More stabilization to tests

* fix
2020-07-14 13:25:24 -07:00
Mikel Blanchard 65365a9a94
Fixed a typo breaking non-signed builds of Jaeger. (#814)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-14 10:16:08 -07:00
Eddy Nakamura 78648afdf6
Adding step to add dotnet version 2.1.x (#813)
* Adding step to add dotnet version 2.1.x

* updating displayName
2020-07-14 09:47:51 -07:00
Mikel Blanchard 9298e0ef3f
Redis instrumentation with ActivitySource by Eddy & Mike (#800)
* Attempting to get Redis instrumentation up and working using ActivitySource API.

* updating tests

* renaming and updating tests

* Test fixes.

* Fixed Redis net461 tests failing on connection.

* Redis integration tests and bug fixes.

* Adding tests

* Put back redis connection options.

* Updates for changes in master.

* adding comments to testRedis

* updating based on comments

* updating summary

* Switched a couple spots using string keys to constants.

* Redis integration tests

* Small tweak to the GitHub action to make it more consistent with the others.

* Made instrumentation internal. Updated README.

* rename MaxFlushInterval to FlushInterval, adding flushInterval to samples

* Removed running of non-integration tests from Redis dockerfile.

Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-14 08:47:59 -07:00
Peter Wiese 3214f1cd96
Wire up the Activity Resource to the OTLP exporter (#807)
* Wire up the Activity Resource to the OTLP exporter

* Adding some test coverage for the change

* ?? Resource.Empty is unnecessary
2020-07-13 18:50:28 -07:00
Eddy Nakamura 2b2dd85cf8
Solving minver issue (#804) 2020-07-13 11:44:28 -07:00
Eddy Nakamura 7e1ca5b93d
Changing namespace for otlp / console exporters (#798)
* Changing namespace for otlp

* updating OT.Exporter.Console namespace as well

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-10 13:45:46 -07:00
Cijo Thomas 987218dac2
BatchingActivityProcessor test to dispose correctly (#801) 2020-07-10 12:33:25 -07:00
Cijo Thomas dfe16544d6
Experiment listening to SDK eventsource logs from unit test (#796)
* Experiment listening to SDK eventsource logs from unit test

* minros

* rename

* test fix

* typo

* fix

* tpo
2020-07-10 12:11:30 -07:00
Cijo Thomas 4abc57d02e
Fix and disable HttpWebRequest test (#797) 2020-07-10 08:55:41 -07:00
Eddy Nakamura d237438115
Remove SpanExporter from otlp (#794)
renaming class/file

renaming to exporterRequest

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-09 23:54:36 -07:00
Eddy Nakamura b7b0b2cd92
Remove SpanExporter from Zipkin (#795)
updating zipkinexporterbenchmarks and removing zipkinTraceExporter/Tests

updating TestRedis

adding testjaeger text

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-09 21:57:34 -07:00
Rajkumar Rangaraj 1ed4107695
Add ForceFlush to ActivityProcessor (#788)
* Added forceflush

* Modified forceflush to flush activity object created before this call.

* Resolving conflict

* Resolving conflict

* Fix tests.

* changed API summary

* Added ConfigureAwait, processors count to task list

* Changes API summary
2020-07-09 21:50:22 -07:00
Eddy Nakamura 4d9d4a014a
Updating reference from SpanExporter to ActivityExporter for Jaeger (#793)
* Remove SpanExporter from Jaeger

renaming files and updating references

merging JaegerExporter and JaegerTraceExporter

merging tests

update

* removing comment
2020-07-09 17:40:18 -07:00
Cijo Thomas db781d2dfd
Remove span based examples from console examples. (#792) 2020-07-09 13:33:47 -07:00
Eddy Nakamura 1c5872ee26
Adding more tests to AspNetCore (#787)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-09 12:39:23 -07:00
Reiley Yang 8ec93bd0b7
improve PR template (#791) 2020-07-09 11:56:29 -07:00
Cijo Thomas bd65fd2132
Remove TracerFactory from Extensions.Hosting project (#790)
* Removed hosting extensions using tracerfactory

* rename

* test

* comment
2020-07-09 09:40:51 -07:00
Eddy Nakamura 0973b3ea0a
Enable netcoreapp2.1 (#780)
updating yml

Revert "updating yml"

This reverts commit 391f3baadbca0de4b3e2d78b35db38eb7e7bddbc.

installing dotnet 2.1 and 3.1

updating yml to enable multiple dotnet versions

adding matrix condition

disable dotnet 2.1 for windows

removing unused package reference

Revert "removing unused package reference"

This reverts commit 0d898aa044f916743da613a83539f568bff3ad49.

updating yml

adding cov.yml to sln

Add resources to instrumentation (#779)

* Add resources to instrumentation

* Unit test activitysourcedapter

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

disabling ubuntu-latest to codecoverage

removing extra steps

adding codecov.yml

moving file

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-08 11:42:51 -07:00
Cijo Thomas c5e5604115
Remove span exporter from ConsoleExporter (#783)
* Remove SpanExporter from ConsoleExporter. Only Activity exporter needs to remain.

* rename console activity exporter to just console exporter

* change example dotnet run

* minor
2020-07-08 11:23:59 -07:00
Cijo Thomas a36236f74e
AspNetCore instrumentation fix for null tag (#786)
* AspNetCore instrumentation fix for null tag

* fix
2020-07-08 10:46:02 -07:00
Mikel Blanchard 049f72c0b4
Added Sql connection-level attributes (from spec) as an opt-in feature. (#782)
* Added Sql connection-level attributes (from spec) as an opt-in feature.

* Code review feedback.
2020-07-07 22:37:08 -07:00
Cijo Thomas 8f0cf0bd1a
Add resources to instrumentation (#779)
* Add resources to instrumentation

* Unit test activitysourcedapter

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-07-07 15:42:29 -07:00
Mikel Blanchard a48ff18b23
Added instrumentation for netfx SqlClient. (#761)
* Added instrumentation for netfx SqlClient.

* Code review.

* Send "db.statement_type" instead of "db.statementType".

* Added integration tests for SqlEventSource.

* Adding .github folder to solution.

* Added a couple missing files into the solution.

* Added FakeSqlEventSource tests.

* Fixed up GrpcClientDiagnosticListener for EventSource changes.

* Removed extra ActivityListener from unit tests.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-07 13:01:45 -07:00
Cijo Thomas cdf0cbe397
Modify readme to show CI status badge. (#775)
* Modify readme to show CI status badge.

* refac

* layout ix

* remoe extra line

* spacing
2020-07-07 12:52:36 -07:00
Cijo Thomas ca322b3883
Remove a azure file left off somehow from earlier cleanup (#776) 2020-07-07 06:48:02 -07:00
Eddy Nakamura 938343c85f
Enable codecov for windows (#777)
cleaning props/targets

updating to new version of codecov

adding env_vars

updating yml

adding env_vars

solving compilation issue

adding source root

adding source root

fixing wrong tag

commenting sourceroot

enabling deterministic for packs only

changing job titles

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-07 06:29:45 -07:00
Cijo Thomas b68670322a
Add GH Action trigger for master branch merge. (#774)
* Add GH Action trigger for master branch merge.

* master for code coverage
2020-07-07 06:12:28 -07:00
Alan West 1b513721c9
Create GrpcTagHelper class (#771)
* Pull logic out of gRPC client instrumentation into helper class + add tests

* Fix parsing rpc.service with package that has multiple parts

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 23:15:35 -07:00
Eddy Nakamura d476b5f8fe
Adding Code Coverage (#770)
removing coverlet.msbuild

testing cov

temp moving

removing linux from cov

adding steps

commenting report part

updating dotnet tool command

changing to no-restore

adding configuration release

enabling disableappdomain

updating order

fail-fast false

updating path

updating path

undoing

changing to linux (faster)

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 22:53:23 -07:00
Cijo Thomas 8e499cd6b2
Remove Azure devops pipeline as GH actions is enabled now. (#772)
* Remove Azure devops pipeline as GH actions is enabled now.

* remove ci file from vs solution
2020-07-06 22:40:19 -07:00
Eddy Nakamura f95f3730fb
updating minver version (#768)
adding target after minver

adding correct revision number

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 21:59:10 -07:00
Rajkumar Rangaraj 5ebc27f94d
Modified JaegerActivityExporter/OpenTelemetryProtocolActivityExporter to accept custom processor (#763)
* Create rajrang123

* Modified overload methods for Console, Jaeger and OTLP exporter to accept custom processor.

* Fixed line break

* Swapped processorConfigure/SetExporter

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 18:19:50 -07:00
Rajkumar Rangaraj 9a751589fd
Batching activity processor (#755)
* Added BatchingActivityProcessor

* Fixed test case.

* Refactored tests

* Matched OT spec by adding exporterTimeoutMillis

* Incorporated Reiley's feedback

* Update TestActivityExporter.cs

* Fix test

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 17:02:46 -07:00
Alan West 401737eada
gRPC client instrumentation (#687)
* Wire up Grpc.Net.Client instrumentation

* Fix missed namespace change

* Fix typos

* Make regex private static

* diagnosticSourceSubscriber cannot be null

* Use grpc.method tag from activity for span name and service attribute

* gRPC instrumentation set Span.Status

* Revert "gRPC instrumentation set Span.Status"

This reverts commit be89687865.

* Set span.Status from grpc.status_code tag on activity

* Remove code and comments regarding context propagation

* Remove OnException override. GrpcClient does not have an OnException event.

* Update GrpcClient instrumentation to use ActivitySource

* Add simple test of GrpcClient instrumentation

* Remove usused method

* Remove Grpc.Core reference and use version 2.25.0 of other Grpc dependencies

* Throw if activitySource is null

* Retrieve Activity.Kind PropertyInfo once

* Add grpc.system attribute

* Update rpc.service attribute per change to RPC spec

* Make ActivityKindPropertyInfo static

* Change default URI to localhost

* Add rpc.method attribute to span

* Add rpc.service and rpc.methods attributes only on successful match

* Add constants for the tags sourced from the Grpc.Net.Client library

* Simplify test scaffolding for Grpc tests

* Add test showing spans collected from Grpc instrumentation and underlying HttpClient instrumentation

* Include package in rpc.service attribute

* Make GrpcClientInstrumentation internal

* Validate that the HTTP span is a child of the gRPC span

* Set Activity.DefaultIdFormat in constructor

* After making call to gRPC stop the test host

* Revert "After making call to gRPC stop the test host"

This reverts commit e7a7cbb8ed.

* Upgrading gRPC dependencies to 2.30.0-pre1 to resolve test flicker

* Use Grpc.Tools 2.25.0

* Replace Grpc.AspNetCore reference with Grpc.AspNetCore.Server

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 16:07:14 -07:00
Alan West 47120b4199
Make HttpClientInstrumentation and SqlClientInstrumentation internal (#766)
* Make HttpClientInstrumentation and SqlClientInstrumentation internal

* Make AspNet and AspNetCore instrumentation internal

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 12:42:45 -07:00