* Removing Todos
renaming parameter
adding tests
updating spanbuilderShim
updating to internal
renaming to spanAttributes
solving build issue
adding spec reference
Continue Refactoring TracerProvider. (#1035)
* optimize the flow
* fix instrumenataion
* move mroe things to provider ctor
* move logic arounds
Co-authored-by: Reiley Yang <reyang@microsoft.com>
changing to class and following spec to replace value
replacing from default to null
updating package
adding xunit.runner
renaming method
* removing duplicated files
* adding some tests and updating to default constructor
* removing to be compliant to spec
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
* Initial make build fix commit
* change Link public API to accept ActivityTagsCollection
* Add more SetAttribute overload to support int bool float and bool
* changelog
* Replace AddTag with SetTag in Activity
* disable a test for temporary progress
* reformat
* url fix
* Update Diagnosticourcepackage
* version fix
* ActivityTagsCollection
* console exporter fix
* one basic test
* minor
* dotnet-format check
updating name
updating order
Update dotnet-format.yml
updating job name
Updating files based on dotnet-format
updating sanitycheck
updating os
* updating workflows
* adding path to editorconfig
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
* Update otlp test
* Converted Span to Activity
* Modified tests
* Changed dispose in tests and added exporters sample
* Renamed all activity to span
* Modified activity to Activity
* Modified existing tests, no need to use Activity based shim
* Modified sample.
* Incorporating Cijo's feedback
* Remove extra SetAttribte and AddEvent overloads on Span
* return bool double and long attribues
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably:
-Missing the Binary injection/extraction of the span context. This doesn't exist with the current implementation of OpenTracing yet.
-Missing explicit timestamps for calls to OpenTracing ISpan::Log.
-Missing explicit timestamps for calls to OpenTracing ISpan::Finish
-Various calls to set/get baggage are not implemented. Requires OpenTelemetry DistributedContext to be finalized.
Other oddities worth nothing:
-The SpanBuilderShim has some conditional code for calling OpenTel SetCreateChild(true|false)
-The ScopeManagerShim is actively tracking scopes returned by calls to OpenTel WithSpan and associated those with the OpenTel ISpan used when calling WithSpan.
I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend.
The included tests are unit tests only; no E2E tests.
Eddy Nakamura