Trask Stalnaker
cefaecab3f
Use more efficient namedOneOf where possible ( #3200 )
...
* Use more efficient namedOneOf where possible
* Fix - hasClassesNamed does and not or
2021-06-07 11:41:34 +09:00
Trask Stalnaker
de2bdb80b4
Fix netty muzzle ( #3191 )
2021-06-04 11:00:01 -07:00
Anuraag Agrawal
0ad8c1b8ce
Manage Netty transitive dependencies ( #3165 )
...
* Manage transitive Netty versions.
* Finish
* .each to not apply resolutions to muzzle
* Exclude epoll from finatra muzzle
2021-06-03 13:12:32 +09:00
Mateusz Rzeszutek
e1762677da
Refactor HttpClientTest ( #3159 )
...
* Remove unused extraClientSpans() method
* Merge extraAttributes() and hasClientSpanHttpAttributes(uri) into
httpAttributes(uri): this will allow to choose extracted attributes
per URI (for example, OkHttp won't set flavor on connection exception
once it's rewritten to Instrumenter)
2021-06-03 10:54:01 +09:00
Anuraag Agrawal
53cfd73bb3
Enable excluding muzzle dependencies and exclude netty-tcnative ( #3169 )
...
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-06-02 09:42:56 -04:00
Lauri Tulmin
e16cf3001f
Add attributes to netty connection failure span ( #3115 )
2021-05-28 15:01:10 -07:00
Ago Allikmaa
df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic ( #3095 )
...
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic
* Adjust whitespace
* Fix context issue with JAX-RS
* Rerun tests
2021-05-27 11:18:11 +03:00
Lauri Tulmin
119697b131
Share some code between netty 4.0 and 4.1 instrumentation ( #3048 )
2021-05-20 14:32:37 -07:00
Lauri Tulmin
23a40d926c
Netty4.1: remove our handler when original handler is removed ( #3026 )
...
* Netty4.1: remove our handler when orignal handler is removed
* Update instrumentation/netty/netty-4.1/javaagent/src/test/groovy/ChannelPipelineTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* disable epoll to see whether it makes any difference
* fix netty with epoll/kqueue native library
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-19 10:01:56 -07:00
Lauri Tulmin
87bc1c69dc
Exclude failing netty version from muzzle ( #3038 )
2021-05-19 09:53:09 -07:00
Trask Stalnaker
d1946f6774
Don't use type annotation style ( #3023 )
2021-05-18 10:23:09 -07:00
Mateusz Rzeszutek
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
Lauri Tulmin
b4b102dbec
Enable http client connection failure tests ( #2998 )
2021-05-17 12:15:48 -07:00
Anuraag Agrawal
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
Trask Stalnaker
cd3dd581f9
Fix some remote connection tests ( #2933 )
2021-05-10 12:19:39 +09:00
Mateusz Rzeszutek
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
Lauri Tulmin
9464134ffd
Test failing async http request ( #2812 )
2021-04-19 14:11:27 -07:00
Trask Stalnaker
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
Trask Stalnaker
3bc058b10b
Don't create duplicate headers ( #2727 )
...
* Test infra
* Update examples
* Update instrumentation
* Update tests
* jaxrs-client fixes
* Remove doRequest/doReusedRequest
* Fix muzzle
* some fixes
* fix test
* doc
* not private
* Apply to doRequestWithCallback also
* Update doc
* groovy
* better
* Don't hardcode traceparent
* Reuse request in SpringRestTemplateTest
2021-04-12 12:21:16 +03:00
Nikita Salnikov-Tarnovski
692bb72f22
Implement concurrent test for Netty http server ( #2750 )
2021-04-08 08:36:42 +03:00
Anuraag Agrawal
d8f6018ba6
Split HttpClientTest execution methods for sync and callback ( #2675 )
2021-04-06 15:26:01 -07:00
Trask Stalnaker
25dd2cf194
Verify span kind in all tests ( #2715 )
2021-04-05 12:57:48 -07:00
Trask Stalnaker
0ce9ca57d9
Move attributes to span builder for use by samplers ( #2587 )
...
* Move attributes to span builder for sampler use
* Fix test
* Remove unnecessary test
2021-03-17 15:02:56 +02:00
Mateusz Rzeszutek
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
Anuraag Agrawal
4a4482c025
Use ClassValue instead of ClassLoader -> Class weakmap since it should be same thing. ( #2559 )
2021-03-11 11:38:32 -08:00
Mateusz Rzeszutek
fe4d95a689
Refactor BaseTracer#onError() method (and unwrapThrowable()) ( #2513 )
...
* Refactor BaseTracer#onError() method (and unwrapThrowable())
Also remove the deprecated BaseTracer(Tracer) constructor.
* Update BaseTracer javadoc
* fix tests
* Code review comments
2021-03-08 15:08:26 +02:00
Mateusz Rzeszutek
72ffb3b7c5
Make BaseTracer fields private ( #2492 )
...
* Make BaseTracer fields private
By making `tracer` private we're forcing all tracer implementation to use the `spanBuilder()` utility method and pass the parent context manually.
2021-03-05 10:54:00 -08:00
Mateusz Rzeszutek
c18acb858e
Add BaseTracer#inject() method ( #2453 )
...
* Add BaseTracer#inject() method
And avoid using GlobalOpenTelemetry#getPropagators()
* Code review comments
2021-03-02 15:30:04 +01:00
Trask Stalnaker
62f2611486
Update instrumentation names ( #2433 )
2021-03-01 19:34:25 -08:00
Nikita Salnikov-Tarnovski
573e512eda
Reworking context propagation for Netty 4.0 ( #2323 )
...
* Reworking context propagation for Netty 4.0
* Spotless
2021-02-22 22:10:01 +02:00
neinoi
1f884e4d97
Fix Operation name logging for Netty based applications ( #2317 )
2021-02-19 09:59:50 -08:00
Anuraag Agrawal
000df967ce
Update to SDK 0.17.0 ( #2338 )
...
* Update to SDK 0.17.0
* Finish
* ottrace
2021-02-19 15:51:55 +09:00
Mateusz Rzeszutek
ee090aee1e
Support library instrumentations with HttpServerTest & HttpClientTest ( #2299 )
2021-02-16 09:05:23 -08:00
Mateusz Rzeszutek
0fbdcad1dd
Make BaseTracer#startSpan() return Context ( #2232 )
...
* Make BaseTracer#startSpan() return Context
* Update instrumentation/apache-camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/CamelEventNotifier.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
* Add Javadocs to BaseTracer
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-12 12:12:40 +01:00
Anuraag Agrawal
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
Anuraag Agrawal
2eee121931
Match classloader when applying netty instrumentation. ( #2099 )
2021-01-22 12:05:20 +02:00
Anuraag Agrawal
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
Lauri Tulmin
2a4e07dce1
Netty: add exception to span ( #2027 )
2021-01-14 09:36:14 -08:00
Pavol Loffay
1070996653
Make factory method for netty 4.0 attribute keys public ( #1995 )
...
* Make factory method for netty 4.0 attribute keys public
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
* Add comment
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
2021-01-14 11:44:51 +01:00
Pavol Loffay
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
Trask Stalnaker
deda1af9c0
HTTP client instrumentation cleanup: netty ( #1909 )
2020-12-15 09:00:31 +02:00
Trask Stalnaker
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
Trask Stalnaker
a2770c311e
Don't use ConfigUtils outside of AgentTestRunner tests ( #1796 )
...
* NetPeerUtilsTest
* RedisCommandNormalizerTest
* InstrumentationModuleTest
* HttpClientTracerTest
* Normalize test config properties
* Create ConfigBuilder in instrumentation-api
* Keep config properties compatible with SDK
2020-12-01 16:52:08 -08:00
Trask Stalnaker
0bd85d7b7f
Pass around context more instead of span (HttpServerTracer) ( #1810 )
2020-12-01 14:49:01 -08:00
Trask Stalnaker
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
Trask Stalnaker
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
Mateusz Rzeszutek
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
Trask Stalnaker
7a6613ca6c
Simplify netty-4.1 AttributeKeys ( #1757 )
...
* Simplify netty-4.1 AttributeKeys
* Suggestions
* Shorten names
* Make same naming changes for netty-4.0
* Update instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_0/AttributeKeys.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2020-11-26 11:49:52 +09:00
Mateusz Rzeszutek
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
Trask Stalnaker
a5a36bd203
Use namespace for attributes put into user classes ( #1739 )
...
* Use namespace for attributes put into user classes
* Add dependency to remove duplication
2020-11-24 12:07:10 -08:00
Mateusz Rzeszutek
45646ff367
Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization() ( #1741 )
...
* Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization()
* Removed no longer needed comments & improved JavaDoc
* Improve TypeInstrumentation Javadoc
2020-11-24 14:27:58 +02:00
Trask Stalnaker
cecdfc2cd0
Update instrumentation names to be consistent ( #1671 )
...
* Update instrumentation names to be consistent
* Remove amqp from rabbitmq package name
2020-11-18 19:53:31 -08:00
Mateusz Rzeszutek
7f36dd1617
Refactor Instrumenters into InstrumentationModules - N, O, P ( #1575 )
2020-11-09 14:42:16 -08:00
Anuraag Agrawal
3d21c26632
Update to SDK 0.10.0 ( #1564 )
2020-11-05 13:17:47 -08:00
Anuraag Agrawal
d3b60a5e33
Rename TRACER to tracer() ( #1540 )
2020-11-02 20:49:51 -08:00
Anuraag Agrawal
c6eee70660
Update to latest snapshot. ( #1524 )
2020-10-29 18:54:09 -07:00
Anuraag Agrawal
dfda406fee
Migrates to using a context when span is started ( #1525 )
...
* Return Context when starting span to preserve baggage.
Co-authored-by: Marcin Grzejszczak <marcin.grzejszczak@gmail.com>
* Use bridge
Co-authored-by: Marcin Grzejszczak <marcin.grzejszczak@gmail.com>
2020-10-29 13:50:54 +02:00
Trask Stalnaker
7244dbf188
Remove unnecessary overrides ( #1477 )
2020-10-25 21:46:14 -07:00
Anuraag Agrawal
f6ad05b8e3
Update to latest SDK snapshot ( #1384 )
...
* Update to latest SDK snapshot
* Use published snapshot
* Fixes
* Cleans
* spotless
* Most
* Clean
* Merge
* Temporarily remove context interop
* WIP
* Prepare for intercepting propagated span
* Bump SDK
* IDE updates
* Lots
* compileJava
* Done?
* bar
* Spot
* drugs
* Groovy--
* green for me
* Spot
* Remove grpc import
* Scrub
2020-10-25 15:14:32 +09:00
Vadim Shaigorodskiy
9e8d663ba4
Remove apache httpclient version ( #1446 )
...
* Remove version from `apache-httpclient` instrumentation
Fixes : #1260
* Remove version from all instrumentation names and add instrumentation name to `spring-web`
Fixes : #1260
2020-10-22 14:22:44 +09:00
Trask Stalnaker
c739f7db6b
Remove unnecessary scopes ( #1351 )
2020-10-11 14:31:37 -07:00
Trask Stalnaker
1b51d4a6b1
Rename packages ( #1367 )
2020-10-11 13:54:35 -07:00
Trask Stalnaker
9605789726
Propagate full context ( #1350 )
...
* Propagate full context
* spotless
2020-10-09 12:58:42 +03:00
Ioannis Mavroukakis
f2de47a150
SpanAssert method names should reflect underlying Span method names ( #1307 )
2020-10-05 16:04:08 +09:00
Anuraag Agrawal
dadaac9a8c
Use 2-line license header to match SDK repo ( #1321 )
...
* Use 2-line license header to match SDK repo
* Apply change
2020-10-05 14:29:56 +09:00
Nikita Salnikov-Tarnovski
e74ffe2e52
Remove support for java7 from buildscripts ( #1229 )
...
* Remove support for java7 from buildscripts
* Remove support for java7 from buildscripts
2020-09-23 15:40:21 +03:00
Nikita Salnikov-Tarnovski
beb1901f5f
Review semantic convention for Http Client spans ( #1214 )
...
* Review semantic convention for Http Client spans
* Polish
* Update instrumentation/google-http-client-1.19/src/test/groovy/AbstractGoogleHttpClientTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-09-18 17:52:08 +03:00
Nikita Salnikov-Tarnovski
7e41b516ee
Review semantic convention for Http Server spans ( #1207 )
...
* Review semantic convention for Http Server spans
* Polish
2020-09-16 09:52:11 +03:00
Nikita Salnikov-Tarnovski
bc98955176
Update to latest otel-java snapshot ( #1057 )
...
* Update to latest otel-java snapshot
* Upgrade to working otel-java snapshot
* Update to latest otel-java snapshot
* Update to latest otel-java snapshot
2020-08-26 22:03:28 +03:00
Helen Y
c4c4558b09
More refactoring ( #1040 )
2020-08-19 15:43:48 -07:00
Trask Stalnaker
5d2ae07797
Use startScope() on all HttpClientTracers ( #971 )
2020-08-18 16:59:30 -07:00
Anuraag Agrawal
bbfdbb39c0
Create abstraction for library dependencies for instrumentation. ( #977 )
...
* Create abstraction for library dependencies for instrumentation.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-08-19 08:57:31 +09:00
Trask Stalnaker
5bce79df36
Remove unnecessary getVersion overrides ( #1004 )
2020-08-16 10:13:35 -07:00
Trask Stalnaker
7159d04b8d
Change groovy import order ( #1013 )
...
* Update docs
* Format all groovy code
* Organize imports
2020-08-15 23:19:27 -07:00
Trask Stalnaker
414213f2d1
Remove final from parameters ( #1003 )
2020-08-15 22:35:51 -07:00
Trask Stalnaker
f893ca540b
Scripted package renaming ( #988 )
2020-08-15 21:55:01 -07:00
Trask Stalnaker
4062d1c9b4
Remove maxJavaVersionForTests from netty-4.0 ( #1006 )
2020-08-15 21:28:25 -07:00
Helen Y
bb235a0aa3
Update package name for tracers ( #991 )
2020-08-14 21:07:18 -07:00
Trask Stalnaker
7818e33178
Package renaming ( #970 )
2020-08-13 20:14:46 -07:00
Trask Stalnaker
b5fbf90977
Extract instrumentation api module ( #884 )
2020-08-09 22:52:33 -07:00
Helen Y
1fcb807590
Refactor HttpClient typed Decorators to Tracers ( #893 )
...
* initial work
* Change OkHttp decorators to tracers
* Change AkkaHttpClient decorator to tracer
* Change ClientDecorator to GrizzlyClientTracer
* Change NettyClientDecorator to Tracer
* Change netty3.8 client decorator to tracer
* Update netty4.1 client decorator to tracer
* Override startScope in child tracers when applicable
* Change KHttpDecorator to tracer
* Change HttpUrlConnectionDecorator to tracer
* Fix muzzle validation failure for grizzly client
* Fix a ratpack client test failure
* Address feedback
* Update delegate for setPeer
* Remove nested try
* Remove unnecessary null check
* Remove asserts
* Add a comment for overriding startSpan(String spanName)
* Remove an irrelevant comment
* Throw an exception when getSetter is null
* Change onPeerConnection to static
* Change getSetter() to be abstract
2020-08-06 17:14:19 -07:00
Nikita Salnikov-Tarnovski
46dfa263af
Remove HttpServerTestAdvice ( #897 )
...
* Remove HttpServerTestAdvice
* Trying to fix
2020-08-06 13:05:55 +03:00
Trask Stalnaker
303d8f427f
Add response generic parameter to HttpServerTracer ( #870 )
2020-08-03 12:52:55 -07:00
Frank Spitulski
adab0efcd6
feat(tags): http ( #827 )
...
flavour, user agent, client ip
2020-07-29 23:57:12 -07:00
Anuraag Agrawal
f6594e1a67
Use Span.recordException for logging throwable ( #813 )
...
* Use Span.recordException
* Fix tests
* Cleanup
* Update instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Spotless (IntelliJ acts weird with groovy files for me :()
* Update for merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-07-28 14:44:42 +09:00
Helen Y
86c438b154
Remove final from local variables ( #732 )
...
* Remove final from local variables
2020-07-20 13:53:34 +09:00
Alexey Zhokhov
f3421e91a0
Remove Lombok ( #672 )
...
* Gradle 6.5.1.
* Skip download javadoc and sources automatically in IntelliJ IDEA.
* Added mavenLocal to repositories.
* Removed Lombok usage.
* Removed duplicated idea config.
* Code format.
* Removed useless usage of Objects.requireNonNull.
* Use instanceof to comparing objects.
* Code format.
* Code format.
* Fixes after merge.
* Fixed sneakyThrow exception.
* Code format.
2020-07-18 15:52:55 +03:00
Nikita Salnikov-Tarnovski
9b6b5e621f
Remove http server decorator ( #701 )
...
* Ratpack migrated from ServerDecorator
* Finatra migrated from ServerDecorator
* Play 2.3 migrated from ServerDecorator
* Play 2.4 migrated from ServerDecorator
* Play 2.6 migrated from ServerDecorator
* Polish
* Polish
* Organize imports
* Relax muzzle checks
* Ratpack version 1.4 is now supported
* Fix muzzle failures on Play
2020-07-17 20:14:19 +03:00
Nikita Salnikov-Tarnovski
9f1ffbe38c
Remove attribute `span.origin.type` ( #712 )
2020-07-16 10:00:45 -07:00
Sergei Malafeev
b78abac82c
#598 Rename "tags" to "attributes" ( #645 )
2020-07-07 21:03:41 -07:00
Nikita Salnikov-Tarnovski
a62801649f
More fixes for Gradle warnings ( #643 )
...
* More gradle deprecation warnings fixed
* More gradle deprecation warnings fixed
* More fixes
* More fixes
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2020-07-07 15:02:07 +03:00
Nikita Salnikov-Tarnovski
3a4470f800
Server spans ( #634 )
...
* Milestone 1
* Netty 4.1 done
* Netty 4.0 done
* Netty 3.8 done
* All tests pass
* Test fix
* Last proper server tracers done
* Format fix
* Tests fixed
* Polish
* Polish
2020-07-07 13:48:51 +03:00
Anuraag Agrawal
1aae2bd7f0
Add extension point for HTTP client decorators to return headers gene… ( #623 )
...
* Add extension point for HTTP client decorators to return headers generically instead of only user agent.
2020-07-02 14:29:21 +09:00
Anuraag Agrawal
874b157fe5
Newline between license and package. ( #581 )
2020-06-25 13:31:16 -07:00
Anuraag Agrawal
918d3913e3
Populate user-agent in HTTP clients. ( #540 )
2020-06-22 21:13:12 -07:00
Tyler Benson
1b29184e7c
Make rootDir usage consistent ( DataDog/dd-trace-java#1518 )
2020-06-11 10:14:02 -07:00
Nikolay Martynov
c63b4fd9a3
Add scopes to http server response ( DataDog/dd-trace-java#1408 )
2020-05-14 11:49:44 -07:00
Trask Stalnaker
1f0cd54fd7
Remove copyright year from license header ( #322 )
...
* Update template
* Apply template
2020-04-15 11:24:44 -07:00
Trask Stalnaker
a333cfe536
Remove unused getComponentName ( #314 )
2020-04-14 13:29:33 -07:00
Trask Stalnaker
d24159c8d2
Merge tag 'v0.48.0' into dd-merge
2020-04-12 15:20:10 -07:00