Commit Graph

708 Commits

Author SHA1 Message Date
David Taylor 996c5ea493
DEV: Use component references for user menu (#456)
See 9b41700f87 for context.

Passing a reference works before and after that change, so there is no need to introduce a discourse-compatibility entry.
2023-03-24 17:55:23 +00:00
Natalie Tay 7562925e0d
FIX: Also evaluate list controller extensions (#455) 2023-03-23 21:35:12 +08:00
Bianca Nenciu 858636cf72
DEV: Update plugin to match latest guidelines (#450)
This commit updates the plugin to follow the latest guidelines, as
shown in discourse-plugin-skeleton, removing the explicit require calls
and using config/routes.rb for defining all routes.
2023-03-23 11:12:04 +02:00
Discourse Translator Bot 2e5598e818
Update translations (#454) 2023-03-21 14:12:20 -04:00
Kris 9bbd1e8321
UX: clearer assign messages on first post (#452) 2023-03-14 10:19:39 -04:00
Keegan George 32f6747264
FIX: Missing actions icon (#453) 2023-03-13 10:45:06 -07:00
Kris 22000f2a5e
UX: fix status alignment after core change (#451) 2023-03-10 16:49:10 -05:00
Penar Musaraj 99e5bb48c9
Revert "DEV: Update plugin to match latest guidelines (#448)" (#449)
This reverts commit 8548df4138.
I suspect this is causing smoke tests to fail. Reverting to confirm.
2023-03-08 14:53:50 -05:00
Bianca Nenciu 8548df4138
DEV: Update plugin to match latest guidelines (#448)
This commit updates the plugin to follow the latest guidelines, as
shown in discourse-plugin-skeleton, removing the explicit require calls
and using config/routes.rb for defining all routes.
2023-03-08 15:15:12 +02:00
Discourse Translator Bot aec66333f4
Update translations (#447) 2023-02-21 17:11:14 +01:00
Bianca Nenciu d8ad876368
DEV: Update plugin to match latest guidelines (#446)
- Define extension modules
- Use different files instead of plugin.rb
- Make sure the plugin is disabled according to the setting
2023-02-17 17:35:41 +02:00
Discourse Translator Bot c95c520a6e
Update translations (#443) 2023-02-15 10:50:18 +01:00
David Taylor d2cc2c4345
DEV: Make basic-assigned-topic-list a real component (#444)
Re-exporting the BasicTopicList component as-is leads to unexpected behavior when colocating templates because `BasicAssignedTopicList` === `BasicTopicList`. Extending it gives the component its own identity.

Similar to 8ba7b0727a
2023-02-14 13:39:15 +00:00
Kris e3a5db4e63
UX: improve custom icons for group assign (#441) 2023-02-13 17:19:25 -05:00
David Taylor 8ba7b0727a
DEV: Make assigned-topic-list a real component (#442)
Re-exporting the TopicList component as-is leads to unexpected behavior when colocating templates because `AssignedTopicList` === `TopicList`. Extending it gives the component its own identity.
2023-02-13 17:54:30 +00:00
Kris c6e6a883f6
UX: remove whitespace in assign tag (#440) 2023-02-08 09:29:50 -05:00
Alan Guo Xiang Tan 460223d7e6
DEV: Remove viewing personal messages test on old user navigation menu (#439)
Core is moving towards the redesigned user page navigation menu so the
old test is no longer required.
2023-02-02 15:44:57 +08:00
Kris e724a7ee69
UX: class for small posts when assigns are private (#400)
The goal is to add a class so when assigns are not public, their descriptions can be styled similar to whispers... this is a light way to reassure admins of assign message visibility.
2023-02-02 15:11:53 +08:00
Krzysztof Kotlarek a907a98d87
FIX: n+1 in search result (#438)
When assignment data is preloaded, cache variable should be set when topic is assigned but also when topic is not assigned to avoid additional queries.
2023-02-01 16:28:21 +11:00
Bianca Nenciu a9b44a973c
FIX: Use same limit as default for user search (#437) 2023-01-26 16:28:30 +02:00
Bianca Nenciu f34bc92b40
FIX: Do not expand if assignee username present (#434)
This does not work as expected and can lead to a worse user experience.
2023-01-25 10:08:34 +02:00
Discourse Translator Bot 7e7da1a876
Update translations (#436) 2023-01-24 16:30:42 +01:00
chapoi 0c0fcbc5af
UX: fix list being limited by modal size (#435) 2023-01-24 13:19:01 +01:00
chapoi 4934df94e2
UX: add ellipsis for assign modal (#433)
* UX: add ellipsis for assign modal

* UX: remove suggestions label
2023-01-23 18:48:17 +01:00
chapoi 0d695df595
UX: fixing alignment issue (#432)
* UX: fixing alignment issue
2023-01-23 18:47:00 +01:00
Krzysztof Kotlarek c036d030dc
FIX: reassign when assignment limit is fulfilled (#419)
Previously, when topic was already assigned 5 times, reassign was not possible. User had to first unassign topic and then assign to someone else.
2023-01-20 13:34:22 +11:00
Selase Krakani 803f73f837
FIX: Deactivate active assignments attached to deleted targets (#428)
Before the implementation of the `post_destroyed` event handler in
the plugin, soft deleting assigned posts/topics did not deactivate the
assignment.
This left sites which assigned and deleted posts/topics before the
introduction of the event handler with 'orphaned' assignments in the UI.

This change deactivates these orphaned assignments.
2023-01-18 19:53:20 +00:00
Bianca Nenciu 02b9d9423e
UX: Add suggestions label to assign modal (#429) 2023-01-18 17:43:23 +02:00
Discourse Translator Bot a20eed02f3
Update translations (#431) 2023-01-18 11:42:05 +01:00
Jan Cernik a7df68b9c2
FIX: System tests failing due to assignee chooser (#430)
Since now the assignee chooser opens automatically, clicking on it was causing it to close
2023-01-17 09:55:21 -03:00
Jan Cernik 896d0e3445
FIX: Broken posts when assigning a closed topic (#425)
The previous behavior was:
1. Assign a topic to someone
2. Close the topic with the setting unassign_on_close enabled
3. Assign the topic to the same user as before

This caused small broken or empty posts to be displayed.

This commit also introduces system specs
2023-01-17 08:09:35 -03:00
Bianca Nenciu 6672ad1ff4
FEATURE: Automatically open assignee chooser (#427) 2023-01-13 17:22:13 +02:00
Bianca Nenciu 1268048874
FEATURE: Show user status when search assignees (#426)
The suggestions are displayed in email-group-user-chooser and user
status is displayed if it exists.
2023-01-12 22:31:48 +02:00
Discourse Translator Bot 4b430ae36e
Update translations (#423) 2023-01-10 20:53:45 +01:00
discoursebot 4eeee568af
DEV: Update CI workflows (#424)
Co-authored-by: discoursebuild <build@discourse.org>
2023-01-10 18:03:19 +00:00
chapoi 509ee637cf
UX: fix text alignment assign modal dropdown (#422) 2023-01-06 14:09:27 +01:00
Ted Johansson 31389d713a
FIX: Build correct assign tag links when using subfolders (#420)
The tag links added to the topic header extras aren't aware of
subfolder usage. This change fixes that.
2023-01-05 16:04:14 +08:00
David Taylor 4070985316
DEV: Update eslint-config-discourse, use prettier for hbs (#414) 2023-01-04 13:34:49 +01:00
Alan Guo Xiang Tan 4fe2ded608
DEV: Change flaky spec to provide more information when it fails (#418)
This spec has been detected to be flaky by
https://github.com/discourse/flaky-tests-detective which we run
internally. However, I could not reproduce the flakiness after multiple
attempts so I rewrote the assertions such that we set up the
expectations of what `Assignment#assigned_to_id` should be before and
after the triggering of the DiscourseEvent.
2023-01-04 07:27:23 +08:00
Gerhard Schlager 4777d0179c
UX: Rephrase notification message (#417)
* UX: Rephrase notification message

* Fix specs
2023-01-03 21:25:13 +01:00
Discourse Translator Bot 5d7c4ed8f7
Update translations (#416) 2023-01-03 14:45:59 +01:00
Discourse Translator Bot fd68f4266a
Update translations (#415) 2022-12-30 17:49:39 +01:00
dependabot[bot] c1f67664fc
Build(deps): Bump json5 from 2.2.1 to 2.2.2 (#413)
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-29 12:21:44 -05:00
David Taylor b11a5fd391
DEV: Introduce syntax_tree for ruby formatting (#411) 2022-12-29 13:30:03 +01:00
Discourse Translator Bot 9cf451647f
Update translations (#410) 2022-12-28 13:31:58 +01:00
David Taylor 46dd26963c
DEV: Introduce syntax_tree for ruby formatting (#408) 2022-12-23 20:35:55 +00:00
David Taylor 4902ba6993
DEV: Bump rubocop-discourse and correct violations (#409) 2022-12-23 19:55:31 +00:00
Bianca Nenciu 993f7faa8d
FIX: Reset assignee error when modal is shown (#407) 2022-12-21 17:24:17 +02:00
Bianca Nenciu a4ce90e855
UX: Improve assign modal design (#403)
Implements a new design that improves the user experience:

- add a clear cancel button
- add an indication the note is optional
- change the plus icon to a search icon
- show an error when the user tries to assign without choosing an assignee
- move suggestions to default search results
- focus search input when modal is displayed
2022-12-21 14:49:24 +02:00
Rafael dos Santos Silva 700dfe551b
DEV: Ruby 3.1 compat (#406) 2022-12-20 23:17:15 -03:00