Commit Graph

1026 Commits

Author SHA1 Message Date
Reiley Yang dfd8ca0f79
Update the link pointing to main branch (#1753)
* update the spec link pointing to main branch)

* update community repo links
2021-01-29 13:48:22 -08:00
Cijo Thomas 26953a4b87
Trigger CI for main and metrics branch (#1749) 2021-01-29 13:07:37 -08:00
Cijo Thomas 0b19047f9f
fix branch name type (#1748) 2021-01-29 12:51:13 -08:00
Cijo Thomas 0472991390
Modify pack and publish action to take metrics branch as well (#1747) 2021-01-29 12:35:54 -08:00
Cijo Thomas fe24768521
fix spec repo links to main branch (#1746) 2021-01-29 12:07:34 -08:00
Cijo Thomas 91236f1cae
Relax diagnosticsource version requirements (#1745)
* Relax diagnosticsource version requirements

* Update src/OpenTelemetry.Api/CHANGELOG.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2021-01-29 11:16:08 -08:00
Cijo Thomas 29995ec245
Remove metrics from 1.0.0 release (#1743)
* Remove metrics from 1.0.0 release

* remove docs for metrics

* public api change
2021-01-29 10:05:50 -08:00
Victor Lu ccc191f0c6
Optimize unnecessarily allocation when initializing MetricProvider (#1685)
* Optimize unnecessary allocation when using GetOrAdd() on Collection objects

* Refactor SortAndDedup method for LabelSets

* Add Tests for Double versions of Counter and Measures

* Refactor to use TryGetValue/TryGetOrAdd instead of Func<> due to concerns over performance.

* Fix CR/LF to LF

* Refactor to avoid allocation of Func<>

* Fix styling issue

* kick build to start

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-28 18:37:30 -08:00
Victor Lu 6fe93f8d79
Replace DateTime.UtcNow.ToString with a zero-allocation version (#1650)
* Replace DateTime.UtcNow.ToString with a zero-allocation version

* Fix compiler warnings

* Add Unit Test for DateTimeGetBytes

* Fix dotnet-format errors

* Fix style check errors

* Fix compiler errors

* Fix merge issues
2021-01-28 16:59:45 -08:00
xiang17 4b5388bdc1
Allow viewing the log file for SelfDiagnostics for .NET Framework (#1693)
* Fix different FileShare behavior in MemoryMappedFile between .NET Framework and .NET Core for SelfDiagnostics

* Create Stress Test to test self diagnostics log file's file share status

(cherry picked from commit 9fe60757c4254b67c1d166fc5f42eb795d424bf9)

* Revert "Create Stress Test to test self diagnostics log file's file share status"

This reverts commit 1007ffef42.

* Dispose underlyingFileStreamForMemoryMappedFile after memoryMappedFile is disposed.

* Add unit test for validating that the log file can be opened as read-only by others while being used by SelfDiagnosticsModule

* Remove en-us in links. Clean up config file. Add change log.

* minor: improve wording

* Fix error SA1501: Statement should not be on a single line
2021-01-28 13:03:38 -08:00
Mikel Blanchard 4f39a58048
ZipkinExporter Stuck Batch Fix (#1726)
* Fix batches growing indefinitely when ZipkinExporter can't make a connection. Fixed null activity events spamming when using SuppressInstrumentation.

* Tweaked DiagnosticSourceListener code.

* Warning fixup.

* Added Dispose to Batch<T>. BatchExportProcessor calls dispose on the Batch it creates.

* Code review.

* Code review.

* CHANGELOG updates.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-28 10:25:17 -08:00
Reiley Yang cc93a78bbc
move release related scripts/tools to build folder (#1736)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-27 19:50:57 -08:00
Victor Lu 3c3a7c7460
When collecting measures, do not emit "empty" metrics (i.e. Int64SummaryData where count=0). (#1691)
* Fixes #1666.

# Changes
When collecting measures, do not emit "empty" metrics (i.e. Int64SummaryData where count=0).

* Fix CR/LF warnings

* Add HasData() to Aggregator class

* Add HasData to Aggregator class

* Refactor Method name to be clearer

* Refactor Method name to be clearer

* Update PublicAPI.*.txt files

* Fix flaky test due to thread-safety issues.

* Fix Lint issues

* Fix Unit Test

* Fix Unit Test

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-27 19:33:37 -08:00
Austin Tan 92948e60f9
Resource merge precedence (#1728)
* Reversing this versus other in merge priority

* revised test for new behavior

* Changelog updated

* Changelog updated

* remove extra period

* Fixing more period issues/line breaks

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-27 16:00:51 -08:00
Reiley Yang 9196e567cf
Fix the leftover master to main issues (#1733)
* fix the leftover master to main issues

* use relative link
2021-01-27 15:47:34 -08:00
Cijo Thomas 01dd4abbaf
Rename workflows to target main branch instead of master (#1731) 2021-01-27 14:39:41 -08:00
Cijo Thomas 0e8b423bef
Use a ubuntu based image for integration tests (#1729)
* Use a ubuntu based image for integration tests

* all integrations

* fix se

* se docker updae

* one more try with SE

* use focal image only for build

* use focal for build only in
2021-01-27 13:47:24 -08:00
Utkarsh Umesan Pillai 05bba18f4d
Add propagation to filtered out events from HttpClient (#1707)
* Add propagation to filtered out events

* Fix HttpInstrumentationEventSource.cs

* Added CHANGELOG.md

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-27 06:59:08 -08:00
Austin Tan 9e9987a3a3
Zipkin Span tags will no longer be populated with Resource Attributes (#1663)
* Remove Resource tag population

* Changelog updated

* Removing test case involving Resource

* removing local dictionary of tags, unused

* Making @CodeBlanch 's test changes thank you!

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-26 18:14:16 -08:00
Austin Tan 842daff4d9
Resource attributes fix (#1720)
* Redoing changes from old PR1647

* Changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-26 14:28:11 -08:00
Utkarsh Umesan Pillai 17dd4a7d56
Added instructions to setup Jaegar locally using Docker (#1722)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-26 13:04:52 -08:00
Alan West e04581969b
Rename OtlpExporter -> OtlpTraceExporter (#1667)
* Rename OtlpExporter -> OtlpTraceExporter

* Update PublicAPI

* Update comment

* Update netstandard2.1 PublicAPI

* rename

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-26 12:52:13 -08:00
Morgan McLean c496264192
Add Zoom meeting passcode (#1724)
* Add Zoom meeting passcode

* Update README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-26 12:38:48 -08:00
Utkarsh Umesan Pillai 06666cdef0
Use Trace.WriteLine instead of Debug.WriteLine for the Debug option (#1719)
* Use Trace.WriteLine instead of Debug.WriteLine for the Debug option

* Updated the CHANGELOG.md
2021-01-25 09:36:53 -08:00
xiang17 02adc4cce0
Fix bug of recording events of all severity levels in .NET Frameworks in SelfDiagnostics (#1690)
* Fix bug in SelfDiagnostics

* Add unit tests.

* Remove outdated comment

* Use a dedicated lock object

* Add two more test cases which calls OpenTelemetrySdkEventSource.Log and expect the events to be captured/omitted by SelfDiagnosticsEventListener as configured

* Fix failure under Linux: Emit Error level events to avoid interference of Verbose events from other sources

* remove outdated comment

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-21 10:29:48 -08:00
mbakalov 97ed5f54d4
SqlClient public API renaming proposal for db.statement properties (#1645)
* Rename dbstatement api bools

* Docs update

* Clarify netfx behavior.

* Markdown cleanup

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-20 11:20:16 -08:00
Cijo Thomas c7e5f07037
AssemblyVersion to only use MajorVersion as per dotnet guidelines (#1697)
Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2021-01-15 19:38:34 -08:00
Cijo Thomas ebfe36057b
Add Alan as maintainer (#1700)
* Add Alan as maintainer

* typo in New Relic name
2021-01-15 16:06:49 -08:00
Mikel Blanchard a16c14ce6a
Cache encoded property names for the zipkin json. (#1699)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-14 12:02:31 -08:00
Lu Peng b17278f691
Add checker for passing correct sampling decision for xray (#1355)
* Add checker for passing correct sampling decision when apply xray id generator.

* Added comment

* Update comments.

* Update links.

* Updated CHANGELOG.md

* Fixed the typo and lining

* Moved check inline.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-14 10:09:56 -08:00
xiang17 9b60e1fe8f
Enable integration tests for .NET 5.0 (#1694)
* Enable integration tests for .NET 5.0

* Change configuration for other packages (StackExchangeRedis and SqlClient)

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-14 09:31:15 -08:00
Alan West 23859041ce
Add OTLP exporter integration test (#1671)
* Add OTLP exporter integration test

* Fix typo

* Move DelegatingTestExporter to shared location

* Fix build

* Fix build part 2

* Fix build part 3 - third time's the charm right?

* Fix build part 4 - third time's not the charm.

* Fix TargetFrameworks for OTLP exporter project and add explanation

* Set switch allowing for insecure GrpcChannel for netcoreapp3.1

* Learning to spell is a life-long process

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-13 21:03:31 -08:00
Christian Neumüller 3bb0445aa4
Fix LogRecordTest by using InvariantCulture. (#1683)
* Fix LogRecordTest by using InvariantCulture.

The test would fail if the current locale used something other than a
dot as the decimal separator (e.g. comma).

* dotnet-format
2021-01-11 09:44:08 -08:00
Christian Neumüller 71290dc4d0
Fix RedisProfilerEntryToActivityConverterTests for UTC offset > 0. (#1680) 2021-01-11 09:15:49 -08:00
Moien Tajik 60566b6c88
Update README.md (#1688) 2021-01-09 20:25:01 -08:00
Utkarsh Umesan Pillai e2a908e089
Added SimpleExporter and BatchExporter for Activity and LogRecord (#1622)
* Added SimpleExporter and BatchExporter for Activity and LogRecord

* Updated the .publicApi text files

* Updated the README to use SimpleActivityExportProcessor instead of SimpleExportProcessor<Activity>

* Updated CHANGELOG.md

* Updated CHANGELOG.md

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-06 11:59:19 -08:00
xiang17 c188edb48f
Make all test cases in W3C trace-context test suite pass (#1668)
* Fixing errors in W3CTraceContextTests

* Fix test_tracestate_key_illegal_vendor_format and test_tracestate_key_length_limit

(cherry picked from commit 5a2bd56c8f83b8e9094534084988992184f4fe7e)

* update test run result

(cherry picked from commit 4e23f9aec69c59affb27327e0a624b32a82317cc)

* Fix test_traceparent_version_0x00 and test_traceparent_version_0xff

Note: the bug was introduced in https://github.com/open-telemetry/opentelemetry-dotnet/pull/923/files#diff-670edb2ea7fa1212aab16a9f732dad8b1e2f15801a3eac1bd0824385355d7d97L262

* Validate key with Trace Context v1 https://www.w3.org/TR/trace-context-1/ which has W3C Recommendation status.

* Refactor validator for lower case alpha and digit

* Fix bug in vendor parsing and vendor valid character check.

* Fix typo and add link where magic numbers are defined.

* Adding comments

* Update comment

* Reuse OWS (Optional Whitespace characters). Utilize return value of HashSet.Add. Forbid upper case in traceparent string.

* Use Span and Slice instead of string.Split

* Remove unused OptionalWhiteSpaceCharacters variable

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-06 10:38:49 -08:00
Alan West e24dccbe9f
Do not maintain DOS/Windows style line endings in md files (#1664)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-05 15:11:41 -08:00
mbakalov 2b3e2147cc
SqlClient: parse optional Protocol part of the connection string Data Source (#1684)
* Add protocol support in connection strings

* Add comments.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-04 12:16:43 -08:00
Alan West 4e4f95bb53
OTLP exporter: use Grpc.Net.Client for netstandard2.1 (#1662)
* Use Grpc.Net.Client for netstandard2.1

* Fix AspNetCore example app

* Better comment for Http2UnencryptedSupport switch

* Update PublicAPI

* Update changelog

* Fix line endings

* Suppress instrumentation on export

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-04 11:45:21 -08:00
Christian Neumüller 5e161a993f
Correct definition of ActivitySource name. (#1675)
Spec says at https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#get-a-tracer

> This name must identify the instrumentation library (e.g. io.opentelemetry.contrib.mongodb) and not the instrumented library.

But this README suggested exactly the opposite.
2021-01-04 08:32:26 -08:00
Vishwesh Bankwar 94c2755724
Made oltp class and contructor public (#1653)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-15 08:48:06 -08:00
Mikel Blanchard 8cda9ef394
Status & error flag updates to match spec (#1655)
* Status & error flag updates to match spec.

* CHANGELOG updates.
2020-12-14 15:39:25 -08:00
Vishwesh Bankwar 01dc04710a
Make Jaeger Exporter class and constructor public (#1644)
* Make Jaeger Exporter class and constructor public

* resolving PR comments: reverting TTransport change

* updated changelog

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-08 12:00:38 -08:00
Vishwesh Bankwar 7a3f5e7bbf
Making zipkin exporter class and constructor public (#1643)
* Changing zipkin exporter class and ctor to public

* updated changelog

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-08 11:39:36 -08:00
mbakalov 4808e0559b
RecordException in SqlClient instrumentation (#1592)
* RecordException in SqlClient instrumentation

* Add RecordException to public API.

* RecordException tests for SqlEventSource

* Tests for exceptions in SqlEventSource.

Support different fully-qualified exception types for AdoNet and MDS
sources.

* More unit-tests

* CHANGELOG updates

* Cleanup tests to use semantic conventions

* Make RecordException netcore only

* RecordException removed from netfx public api

Also updated readme and changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-07 10:12:11 -08:00
Utkarsh Umesan Pillai 1fb76952cd
Updated the number of invocations to wait for; Added Assert for each of the processor invocations (#1641) 2020-12-02 11:34:42 -08:00
Utkarsh Umesan Pillai a01063cdbc
Updated LogLevel for events logging exceptions (#1635)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-01 16:36:37 -08:00
Cijo Thomas 479fb50f77
Redis readme clarification (#1638) 2020-12-01 15:40:37 -08:00
Utkarsh Umesan Pillai c0e27a83fd
Add example for InMemory Exporter (#1639)
* Added example for InMemory exporter

* Update examples/Console/Examples.Console.csproj

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Addressed the PR comments

* Fix comments

* Fix markdown

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-12-01 15:15:34 -08:00