Commit Graph

763 Commits

Author SHA1 Message Date
Kris 7fe45c8eb5
UX: simplify markup to fix j/k highlighting (#516)
This cleans up the markup a bit, so instead of a `div` as a table child we use the `td` and removes the internal wrapper. This fixes an issue with a double highlight while using j/k navigation highlighting caused by the nested `td`.
2023-10-20 08:40:55 +08:00
dependabot[bot] 92b0dd530b
Build(deps): Bump @babel/traverse from 7.22.17 to 7.23.2 (#515)
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.17 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-19 11:54:27 +02:00
Natalie Tay e434be7969
UX: Don't change topic notification level when unassigning (#513)
* UX: Don't change topic notification level when unassigning

* Update test
2023-10-16 04:41:44 +00:00
Discourse Translator Bot 2185513d96
Update translations (#514) 2023-10-11 11:17:57 +02:00
Krzysztof Kotlarek 0c01e8fdfd
FIX: granular webhooks (#498)
After those core changes we need additional translations

https://github.com/discourse/discourse/pull/23070
2023-10-09 03:26:40 +00:00
David Taylor df34e91b55
DEV: Resolve routing method deprecation (#512)
Uses the router service for redirecting instead of `this.transitionTo`. Also removes the first branch of logic, which was unnecessarily redirecting to the current route (and led to an infinite loop with the modern API)
2023-10-02 15:10:31 +01:00
David Taylor 93ee2cb886
DEV: Update AssignedTopicListColumn class name (#511)
The `_Test` suffix shouldn't have been included in 89807545a4. No functional change.
2023-10-02 13:15:39 +01:00
David Taylor 89807545a4
DEV: Modernise assignment topic-list implementation (#510)
- Reuse core `<BasicTopicList` instead of reimplementing
- Use raw plugin outlet to add assign controls to topic-list-item (requires https://github.com/discourse/discourse/pull/23592)
- Remove use of `.render()` in route
2023-09-28 15:07:15 +01:00
Jarek Radosz e9c7cb5c3f
DEV: Skip a flaky spec (#508) 2023-09-12 07:43:24 +08:00
Martin Brennan 7c18124a32
DEV: Fix REMINDER_BUFFER_MINUTES const reassignment warning (#506)
Without ||=, ruby warns the const is being reassigned all the time.
2023-08-31 12:51:51 +10:00
Discourse Translator Bot d28c06a973
Update translations (#505) 2023-08-29 15:50:21 +02:00
Jarek Radosz a5fb9a5e1f
DEV: Fix a core deprecation (#504)
Re-lands #475
2023-08-28 10:02:29 +02:00
Renato Atilio 4ff42c19a2
FIX: move comment out of the translation value (#503) 2023-08-24 16:47:13 -03:00
Discourse Translator Bot 5551ab4d2f
Update translations (#502) 2023-08-23 09:29:04 +02:00
Penar Musaraj de12879522
DEV: Pin plugin for Discourse 3.1 stable (#501) 2023-08-22 13:45:43 -05:00
Discourse Translator Bot 0cbf10b805
Update translations (#500) 2023-08-15 21:24:43 +02:00
Natalie Tay 55f8d24b1f
DEV: Increase the buffer used to determine whether to send out the reminder email (#499)
Increase the buffer used to determine whether to send out the reminder email
2023-08-15 14:12:10 +08:00
Natalie Tay f5cc748986
FIX: Fix reminder frequency not getting sent daily when early by a few seconds/minutes (#496)
Add a buffer in determining whether to remind a user about assignments
2023-08-10 12:04:27 +08:00
Discourse Translator Bot a0bd07115e
Update translations (#497) 2023-08-08 15:42:18 +02:00
Joffrey JAFFEUX 8f04d82ae7
DEV: skip flakey spec (#495)
We already tried to make this spec more reliable in eb3b97b834 but that didn't work out.

https://github.com/discourse/discourse/actions/runs/5694495045/job/15435791690?pr=22860
2023-07-28 19:31:55 +02:00
dependabot[bot] 80f3046755
Build(deps): Bump word-wrap from 1.2.3 to 1.2.4 (#494)
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-19 01:32:19 +02:00
Jarek Radosz 458306fa6b
DEV: Use the new bulk topic actions api (#491) 2023-07-18 14:15:16 +02:00
Kris 43cb34c698
FIX: missing space in assign button (#493) 2023-07-13 19:18:05 -04:00
Alan Guo Xiang Tan eb3b97b834
DEV: Try to make system tests more stable (#492)
Why this change?

We have been seeing tests failures due to errors like

```
Capybara::ElementNotFound:
  Unable to find css "#topic-footer-button-assign"
```

when running our system tests in CI. However, I can't quite figure out
why that is happening and have invested way too much time to do so.
Therefore, I'm trying to fix this by closing a topic via the topic
timeline controls instead of the footer button instead.
2023-07-12 08:31:24 +08:00
Jarek Radosz 1c079b792b
DEV: Use the new component-based modal API (#489)
Co-authored-by: David Taylor <david@taylorhq.com>
2023-07-11 10:37:57 +02:00
dependabot[bot] a4ea754c1d
Build(deps): Bump semver from 6.3.0 to 6.3.1 (#490)
Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-11 10:37:04 +02:00
Isaac Janzen 41f62d9ea9
DEV: Convert dismiss modal to component-based API (#481) 2023-07-06 12:14:36 -05:00
Alan Guo Xiang Tan 7867cc4b03
DEV: Fix incorrect fabrication leading to index violation errors (#488)
This was causing the tests to be flaky with the following errors on CI:

```
PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_assignments_on_target_id_and_target_type"
       DETAIL:  Key (target_id, target_type)=(39, Topic) already exists.
```
2023-07-06 07:30:41 +08:00
Natalie Tay 76f92ba253
DEV: Fabricate assignments (#487)
- Fabricate and use slightly more accurate names for users and groups
- Use fabricator instead of assigner in controller setup
- Remove unneeded user
2023-07-05 15:23:34 +08:00
Martin Brennan 7d9207a275
DEV: Try fix flaky spec (#485)
For some reason sometimes clicking the admin wrench doesn't work
2023-07-05 12:10:48 +10:00
Jarek Radosz 47a1170ec5
DEV: Merge js dirs; prefix tests (#484) 2023-07-03 17:28:02 +02:00
Natalie Tay 59fa9d7dbf
FIX: Sum assignments for group and group users (#482)
Use the assignment count rather than the number of topics assigned for the number of assignments in the nav
2023-07-03 10:58:46 +08:00
Jarek Radosz f89420d00e
DEV: Remove unused `assignUser` action (#483) 2023-06-30 19:18:15 +02:00
Jarek Radosz 2bff29e919
DEV: Modernization/cleanup (#480)
* Component template colocation
* Native classes
* glimmer plugin connector
* `this.` in templates
* `?.` operator
* Merged `withPluginApi` calls
* Updated deps
2023-06-22 10:06:37 +02:00
David Taylor 3ca56e82d7
DEV: Fix Zeitwerk reloading error (#479)
Using `.append` can lead to a 'two routes with the same name' error
2023-06-16 11:32:50 +01:00
Jarek Radosz a476aeb222
Revert "DEV: Fix a core deprecation (#475)" (#478)
This reverts commit 968751c8a9.

To be re-applied when 3.1.0.beta5 is released.
2023-06-01 19:54:52 +02:00
Kris c5877a1456
UX: constrain avatar size due to core change (#477) 2023-06-01 13:42:57 -04:00
Isaac Janzen 6cd56770bc
DEV: Use angle bracket syntax (#476) 2023-05-28 09:34:13 -05:00
Vinoth Kannan fb89a23530
FEATURE: skip group invite if all members can see topic already. (#474)
We don't want to invite a group when all of its members are part of another group that is already allowed to the topic.
2023-05-27 22:29:38 +05:30
Jarek Radosz 968751c8a9
DEV: Fix a core deprecation (#475) 2023-05-26 15:40:40 +02:00
Vinoth Kannan f97da59dee
FIX: don't invite user when already a member of an allowed group. (#473)
Otherwise, when an allowed group member is assigned to the PM it invites the user (which is unnecessary) and creates a public small post for the invite.
2023-05-24 11:45:50 +05:30
Discourse Translator Bot be4a50cf8d
Update translations (#472) 2023-05-23 21:23:18 +02:00
Vinoth Kannan dcaadb75dc
FEATURE: invite user/group to PM if not a participant already. (#471)
When a group or user is assigned to a personal message, if they are not already a participant, invite them to the PM before assignment.
2023-05-22 14:48:08 +05:30
Jarek Radosz c5e0c2c0b3
DEV: Don't use renderTemplate (#469)
See: https://github.com/discourse/discourse/pull/21517
2023-05-19 11:00:56 +02:00
Keegan George f75a6a8354
DEV: Remove `redesigned_user_menu_enabled: true` in tests (#470) 2023-05-17 13:47:30 -07:00
Keegan George 310fb80e54
DEV: Remove old user menu related code (#464) 2023-05-10 15:34:08 -07:00
Ted Johansson afb54c7c1e
DEV: Replace #pluck_first monkey patch with native #pick (#467) 2023-05-09 12:59:41 +08:00
Arkshine d79fea7e4f
FIX: Reassigning to a group creates an incorrect mention's link (#468)
Reported here: https://meta.discourse.org/t/reassigning-to-a-group-creates-a-u-link-in-the-group-mention/263659

Reassigning to a group creates an `/u/` link in the `@group` mention instead of `/g/`.

The reason is the `reassigned_group` group small post action code is not registered.
2023-05-05 10:00:49 +10:00
Arpit Jalan 69cbe1f3ee
FEATURE: allow adding note when bulk assigning topics (#466) 2023-05-02 15:20:44 +05:30
Isaac Janzen ba47a238ac
FIX: properly check key values for shortcuts (#463)
- Update angle bracket components to use vanilla attributes where possible
- Update how we check for key value after changing to `on "change"` from `onChange`
2023-04-28 13:02:13 -05:00